Groundwork for fusion implementation and assorted bug fixes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Output from hospital dataset on master/HEAD: Output from hospital dataset with this patch/PR: The fewer false positives result from fixing "consistency" issues with our normalization of values in #16. |
richardwu
force-pushed
the
fusion-impl
branch
from
6746943
to
01a3ff0
Compare
minafarid
requested changes
Nov 15, 2018
| python test_holoclean.py | ||
| # Launch tests. | ||
| echo "Launching tests..." | ||
| python -m unittest discover . |
richardwu
force-pushed
the
fusion-impl
branch
from
0a7f6cf
to
45cc6a3
Compare
minafarid
requested changes
Nov 20, 2018
richardwu
force-pushed
the
fusion-impl
branch
from
45cc6a3
to
e1b6866
Compare
|
Looks good, please resolve the conflicts and modify the Usage section in the README.md file to refer to the examples folder |
Some notable changes: - Support for loading fusion and/or repair raw datasets. - Imported flights dataset for fusion testing. - Restructured test cases to use unittests. - Removed unnecessary try excepts that caused exceptions to be silenced. - Fixed a few bugs as a result of silenced exceptions. - Keep attributes/columns in their original case (instead of lowercasing everything): modify Postgres queries to quote references to columns.
richardwu
force-pushed
the
fusion-impl
branch
from
e1b6866
to
0005594
Compare
richardwu
force-pushed
the
fusion-impl
branch
from
5454b82
to
734d90b
Compare
|
Rebased and fixed merge conflicts, should be good to merge. |
minafarid
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: please review the latest commit. The first two commits are outstanding from #15 .rebasedCloses #14, #16 .
Some notable changes:
everything): modify Postgres queries to quote references to columns.