-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Groundwork for fusion implementation and assorted bug fixes #18
Conversation
Output from hospital dataset on master/HEAD:
Output from hospital dataset with this patch/PR:
The fewer false positives result from fixing "consistency" issues with our normalization of values in #16. |
6746943
to
01a3ff0
Compare
python test_holoclean.py | ||
# Launch tests. | ||
echo "Launching tests..." | ||
python -m unittest discover . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comments below
0a7f6cf
to
45cc6a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, please see minor comments.
45cc6a3
to
e1b6866
Compare
Looks good, please resolve the conflicts and modify the Usage section in the README.md file to refer to the examples folder |
Some notable changes: - Support for loading fusion and/or repair raw datasets. - Imported flights dataset for fusion testing. - Restructured test cases to use unittests. - Removed unnecessary try excepts that caused exceptions to be silenced. - Fixed a few bugs as a result of silenced exceptions. - Keep attributes/columns in their original case (instead of lowercasing everything): modify Postgres queries to quote references to columns.
e1b6866
to
0005594
Compare
5454b82
to
734d90b
Compare
Rebased and fixed merge conflicts, should be good to merge. |
Note: please review the latest commit. The first two commits are outstanding from #15 .rebasedCloses #14, #16 .
Some notable changes:
everything): modify Postgres queries to quote references to columns.